Skip to content

61 allow custom global pivot finder #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shinaoka merged 6 commits into from
Jun 10, 2025
Merged

61 allow custom global pivot finder #62

shinaoka merged 6 commits into from
Jun 10, 2025

Conversation

@shinaoka
Copy link
Member

@shinaoka shinaoka commented Jun 5, 2025 •
edited
Loading

This PR allows the user to use a custom global pivot finder for TCI2.
A custom global pivot finder type must inherit from TensorCrossInterpolation.AbstractGlobalPivotFinder.

@shinaoka shinaoka linked an issue Jun 5, 2025 that may be closed by this pull request
Allow custom global pivot finder #61
Closed
@shinaoka shinaoka requested a review from rittermarc June 5, 2025 01:40
@rittermarc
Copy link
Member

rittermarc commented Jun 5, 2025

Wouldn't it be cleaner to have AbstractGlobalPivotFinder in globalpivotfinder.jl, and to make the argument type of the functor call an AbstractTensorTrain?

@shinaoka
Copy link
Member Author

shinaoka commented Jun 5, 2025 •
edited
Loading

make the argument type of the functor call an AbstractTensorTrain?

A custom global pivot finder might want to utilize the internal status of the current TCI2, such as local pivots, etc.
Alternatively, we can define a struct that contains information passed from the TCI2 object to the finder.
Or, a dictionary may be fine.

What do you think?

@shinaoka
Copy link
Member Author

shinaoka commented Jun 9, 2025

@rittermarc
Are you OK with the changes?

rittermarc
rittermarc approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@rittermarc rittermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shinaoka shinaoka merged commit 3813134 into main Jun 10, 2025
3 checks passed
@shinaoka shinaoka deleted the 61-allow-custom-global-pivot-finder branch June 10, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rittermarc rittermarc rittermarc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow custom global pivot finder

3 participants

@shinaoka @rittermarc